Преглед изворни кода

Fix: crowi object as a prop

Sotaro KARASAWA пре 9 година
родитељ
комит
40d5a51686
2 измењених фајлова са 5 додато и 6 уклоњено
  1. 1 1
      resource/js/app.js
  2. 4 5
      resource/js/components/PageHistory.js

+ 1 - 1
resource/js/app.js

@@ -42,5 +42,5 @@ Object.keys(componentMappings).forEach((key) => {
 
 // うわーもうー
 $('a[data-toggle="tab"][href="#revision-history"]').on('show.bs.tab', function() {
-  ReactDOM.render(<PageHistory pageId={pageId} />, document.getElementById('revision-history'));
+  ReactDOM.render(<PageHistory pageId={pageId} crowi={crowi} />, document.getElementById('revision-history'));
 });

+ 4 - 5
resource/js/components/PageHistory.js

@@ -8,8 +8,6 @@ export default class PageHistory extends React.Component {
   constructor(props) {
     super(props);
 
-    this.crowi = window.crowi; // FIXME
-
     this.state = {
       revisions: [],
       diffOpened: {},
@@ -26,14 +24,14 @@ export default class PageHistory extends React.Component {
       return ;
     }
 
-    this.crowi.apiGet('/revisions.ids', {page_id: pageId})
+    this.props.crowi.apiGet('/revisions.ids', {page_id: pageId})
     .then(res => {
 
       const rev = res.revisions;
       let diffOpened = {};
       const lastId = rev.length - 1;
       res.revisions.map((revision, i) => {
-        const user = this.crowi.findUserById(revision.author);
+        const user = this.props.crowi.findUserById(revision.author);
         if (user) {
           rev[i].author = user;
         }
@@ -101,7 +99,7 @@ export default class PageHistory extends React.Component {
       return ;
     }
 
-    this.crowi.apiGet('/revisions.get', {revision_id: revision._id})
+    this.props.crowi.apiGet('/revisions.get', {revision_id: revision._id})
     .then(res => {
       if (res.ok) {
         this.setState({
@@ -137,4 +135,5 @@ export default class PageHistory extends React.Component {
 
 PageHistory.propTypes = {
   pageId: React.PropTypes.string,
+  crowi: React.PropTypes.object.isRequired,
 };