Przeglądaj źródła

132486 change early return

soumaeda 2 lat temu
rodzic
commit
3eef8854f1

+ 2 - 2
apps/app/src/components/PageSideContents/PageSideContents.tsx

@@ -45,7 +45,7 @@ const Tags = (props: TagsProps): JSX.Element => {
   const { open: openTagEditModal } = useTagEditModal();
 
   const onClickEditTagsButton = useCallback(() => {
-    if (pageId == null || revisionId == null || tagsInfoData == null) {
+    if (tagsInfoData == null) {
       return;
     }
     openTagEditModal(tagsInfoData.tags, pageId, revisionId);
@@ -59,7 +59,7 @@ const Tags = (props: TagsProps): JSX.Element => {
 
   return (
     <div className="grw-taglabels-container">
-      { tagsInfoData && tagsInfoData.tags != null
+      { tagsInfoData?.tags != null
         ? (
           <PageTags
             tags={tagsInfoData.tags}

+ 2 - 2
apps/app/src/components/PageTags/TagEditModal.tsx

@@ -74,8 +74,8 @@ const TagEditModalSubstance: React.FC<TagEditModalSubstanceProps> = (props: TagE
 export const TagEditModal: React.FC = () => {
   const { data: tagEditModalData, close: closeTagEditModal } = useTagEditModal();
 
-  if (tagEditModalData == null || !tagEditModalData.isOpen) {
-    return;
+  if (!tagEditModalData?.isOpen) {
+    return <></>;
   }
 
   return <TagEditModalSubstance tagEditModalData={tagEditModalData} closeTagEditModal={closeTagEditModal} />;