Improved

packages/app/src/server/service/page-grant.ts

@@ -67,7 +67,7 @@ class PageGrantService {
       // DO NOTHING
     }
     // GRANT_OWNER
-    if (ancestor.grant === Page.GRANT_OWNER) {
+    else if (ancestor.grant === Page.GRANT_OWNER) {
       if (target.grant !== Page.GRANT_OWNER) {
         return false;
       }
@@ -77,7 +77,7 @@ class PageGrantService {
       }
     }
     // GRANT_USER_GROUP
-    if (ancestor.grant === Page.GRANT_USER_GROUP) {
+    else if (ancestor.grant === Page.GRANT_USER_GROUP) {
       if (ancestor.applicableGroupIds == null || ancestor.applicableUserIds == null) {
         throw Error('applicableGroupIds and applicableUserIds are not specified');
       }
@@ -117,7 +117,7 @@ class PageGrantService {
       }
     }
     // GRANT_OWNER
-    if (target.grant === Page.GRANT_OWNER) {
+    else if (target.grant === Page.GRANT_OWNER) {
       if (descendants.descendantGroupIds.length !== 0 || descendants.grantedUserIds.length > 1) {
         return false;
       }
@@ -127,7 +127,7 @@ class PageGrantService {
       }
     }
     // GRANT_USER_GROUP
-    if (target.grant === Page.GRANT_USER_GROUP) {
+    else if (target.grant === Page.GRANT_USER_GROUP) {
       const shouldNotExistIds = excludeTestIdsFromTargetIds(descendants.descendantGroupIds, target.applicableGroupIds);
       if (shouldNotExistIds.length !== 0) {
         return false;

packages/app/src/server/service/user-group.ts

@@ -2,7 +2,7 @@ import mongoose from 'mongoose';
 
 import loggerFactory from '~/utils/logger';
 import UserGroup, { UserGroupDocument } from '~/server/models/user-group';
-import { compareObjectId, isIncludesObjectId } from '~/server/util/compare-objectId';
+import { isIncludesObjectId } from '~/server/util/compare-objectId';
 
 const logger = loggerFactory('growi:service:UserGroupService'); // eslint-disable-line no-unused-vars
 
@@ -61,7 +61,7 @@ class UserGroupService {
 
     // throw if parent was in its descendants
     const descendantsWithTarget = await UserGroup.findGroupsWithDescendantsRecursively([userGroup]);
-    const descendants = descendantsWithTarget.filter(d => compareObjectId(d._id, userGroup._id));
+    const descendants = descendantsWithTarget.filter(d => d._id.equals(userGroup._id));
     if (isIncludesObjectId(descendants, parent._id)) {
       throw Error('It is not allowed to choose parent from descendant groups.');
     }

packages/app/src/server/util/compare-objectId.ts

@@ -3,21 +3,9 @@ import mongoose from 'mongoose';
 type IObjectId = mongoose.Types.ObjectId;
 const ObjectId = mongoose.Types.ObjectId;
 
-const castToString = (val: string | IObjectId) => {
-  if (typeof val === 'string') {
-    return val;
-  }
-
-  return val.toString();
-};
-
-export const compareObjectId = (id1: IObjectId | string, id2: IObjectId | string): boolean => {
-  return castToString(id1) === castToString(id2);
-};
-
 export const isIncludesObjectId = (arr: (IObjectId | string)[], id: IObjectId | string): boolean => {
-  const _arr = arr.map(i => castToString(i));
-  const _id = castToString(id);
+  const _arr = arr.map(i => i.toString());
+  const _id = id.toString();
 
   return _arr.includes(_id);
 };
@@ -30,8 +18,8 @@ export const isIncludesObjectId = (arr: (IObjectId | string)[], id: IObjectId |
  */
 export const excludeTestIdsFromTargetIds = (targetIds: (IObjectId | string)[], testIds: (IObjectId | string)[]): IObjectId[] => {
   // cast to string
-  const arr1 = targetIds.map(e => castToString(e));
-  const arr2 = testIds.map(e => castToString(e));
+  const arr1 = targetIds.map(e => e.toString());
+  const arr2 = testIds.map(e => e.toString());
 
   // filter
   const excluded = arr1.filter(e => !arr2.includes(e));
@@ -42,7 +30,7 @@ export const excludeTestIdsFromTargetIds = (targetIds: (IObjectId | string)[], t
 
 export const removeDuplicates = (objectIds: (IObjectId | string)[]): IObjectId[] => {
   // cast to string
-  const strs = objectIds.map(id => castToString(id));
+  const strs = objectIds.map(id => id.toString());
   const uniqueArr = Array.from(new Set(strs));
 
   // cast to ObjectId