Просмотр исходного кода

fix non-autofixable biome errors

Futa Arai 4 месяцев назад
Родитель
Сommit
3cf406acc1

+ 2 - 1
apps/app/src/server/routes/forgot-password.ts

@@ -28,11 +28,12 @@ export const checkForgotPasswordEnabledMiddlewareFactory = (
       logger.error(message);
 
       const statusCode = forApi ? 405 : 404;
-      return next(
+      next(
         createError(statusCode, message, {
           code: forgotPasswordErrorCode.PASSWORD_RESET_IS_UNAVAILABLE,
         }),
       );
+      return;
     }
 
     next();

+ 3 - 1
apps/app/src/server/routes/login.js

@@ -43,7 +43,9 @@ module.exports = (crowi, app) => {
     const results = await Promise.allSettled(promises);
     results
       .filter((result) => result.status === 'rejected')
-      .forEach((result) => logger.error(result.reason));
+      .forEach((result) => {
+        logger.error(result.reason);
+      });
   }
 
   async function sendNotificationToAllAdmins(user) {

+ 1 - 1
apps/app/src/server/routes/ogp.ts

@@ -96,7 +96,7 @@ module.exports = (crowi: Crowi) => {
       return res.status(500).send(`error: ${err}`);
     }
 
-    let result;
+    let result: { data: any };
     try {
       result = await axios.post(
         ogpUri,

+ 9 - 4
apps/app/src/server/routes/search.ts

@@ -1,5 +1,9 @@
 import ExternalUserGroupRelation from '~/features/external-user-group/server/models/external-user-group-relation';
 import { SupportedAction } from '~/interfaces/activity';
+import type {
+  IFormattedSearchResult,
+  ISearchResult,
+} from '~/interfaces/search';
 import loggerFactory from '~/utils/logger';
 
 import type Crowi from '../crowi';
@@ -119,12 +123,12 @@ module.exports = (crowi: Crowi, app) => {
       order = null,
       vector = null,
     } = req.query;
-    let paginateOpts;
+    let paginateOpts: { limit: number; offset: number };
 
     try {
       paginateOpts = ApiPaginate.parseOptionsForElasticSearch(req.query);
     } catch (e) {
-      res.json(ApiResponse.error(e));
+      return res.json(ApiResponse.error(e));
     }
 
     if (q === null || q === '') {
@@ -154,7 +158,8 @@ module.exports = (crowi: Crowi, app) => {
       vector,
     };
 
-    let searchResult;
+    let searchResult: ISearchResult<unknown>;
+    // biome-ignore lint/suspicious/noImplicitAnyLet: ignore
     let delegatorName;
     try {
       const query = decodeURIComponent(q);
@@ -177,7 +182,7 @@ module.exports = (crowi: Crowi, app) => {
       return res.json(ApiResponse.error(err));
     }
 
-    let result;
+    let result: IFormattedSearchResult;
     try {
       result = await searchService.formatSearchResult(
         searchResult,