Просмотр исходного кода

remove some eslint-disable lines

Yuki Takei 2 месяцев назад
Родитель
Сommit
3a35905152

+ 0 - 4
apps/app/src/client/components/Admin/ImportData/GrowiArchive/ImportCollectionConfigurationModal.jsx

@@ -52,7 +52,6 @@ class ImportCollectionConfigurationModal extends React.Component {
     const translationBase =
       'admin:importer_management.growi_settings.configuration.pages';
 
-    /* eslint-disable react/no-unescaped-entities */
     return (
       <>
         <div className="form-check form-check-warning">
@@ -185,7 +184,6 @@ class ImportCollectionConfigurationModal extends React.Component {
         </div>
       </>
     );
-    /* eslint-enable react/no-unescaped-entities */
   }
 
   renderRevisionsContents() {
@@ -195,7 +193,6 @@ class ImportCollectionConfigurationModal extends React.Component {
     const translationBase =
       'admin:importer_management.growi_settings.configuration.revisions';
 
-    /* eslint-disable react/no-unescaped-entities */
     return (
       <div className="form-check form-check-warning">
         <input
@@ -222,7 +219,6 @@ class ImportCollectionConfigurationModal extends React.Component {
         </label>
       </div>
     );
-    /* eslint-enable react/no-unescaped-entities */
   }
 
   render() {

+ 0 - 1
apps/app/src/client/components/Admin/ImportData/GrowiArchive/UploadForm.jsx

@@ -18,7 +18,6 @@ class UploadForm extends React.Component {
 
   changeFileName(e) {
     // to trigger rerender at onChange event
-    // eslint-disable-next-line react/no-unused-state
     this.setState({ dummy: e.target.files[0].name });
   }
 

+ 0 - 2
apps/app/src/client/components/PageDeleteModal/PageDeleteModal.tsx

@@ -224,7 +224,6 @@ export const PageDeleteModal: FC = () => {
       }
     },
     // Optimization: Use pageIds and pagesLength instead of pages array reference to avoid unnecessary re-computation
-    // eslint-disable-next-line react-hooks/exhaustive-deps
     [
       pageIds,
       pagesLength,
@@ -364,7 +363,6 @@ export const PageDeleteModal: FC = () => {
       </>
     );
     // Optimization: Use direct dependencies instead of JSX.Element reference for better performance
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [
     isOpened,
     t,

+ 4 - 5
apps/app/src/pages/_document.page.tsx

@@ -1,6 +1,7 @@
-/* eslint-disable @next/next/google-font-display */
-import React, { type JSX } from 'react';
+import type { JSX } from 'react';
+// biome-ignore lint/suspicious/noDocumentImportInPage: This project uses _document.page.tsx instead of _document.tsx
 import type { DocumentContext, DocumentInitialProps } from 'next/document';
+// biome-ignore lint/suspicious/noDocumentImportInPage: This project uses _document.page.tsx instead of _document.tsx
 import Document, { Head, Html, Main, NextScript } from 'next/document';
 import type { Locale } from '@growi/core/dist/interfaces';
 
@@ -10,7 +11,7 @@ import loggerFactory from '~/utils/logger';
 
 import { getLocaleAtServerSide } from './utils/locale';
 
-const logger = loggerFactory('growi:page:_document');
+const _logger = loggerFactory('growi:page:_document');
 
 type HeadersForGrowiPluginProps = {
   pluginResourceEntries: GrowiPluginResourceEntries;
@@ -24,13 +25,11 @@ const HeadersForGrowiPlugin = (
     <>
       {pluginResourceEntries.map(([installedPath, href]) => {
         if (href.endsWith('.js')) {
-          // eslint-disable-next-line @next/next/no-sync-scripts
           return (
             <script type="module" key={`script_${installedPath}`} src={href} />
           );
         }
         if (href.endsWith('.css')) {
-          // eslint-disable-next-line @next/next/no-sync-scripts
           return (
             <link rel="stylesheet" key={`link_${installedPath}`} href={href} />
           );

+ 4 - 6
apps/app/src/server/util/express-validator/sanitizer.js

@@ -4,15 +4,13 @@
 const sanitizers = {};
 
 sanitizers.toPagingLimit = (_value) => {
-  const value = parseInt(_value);
-  // eslint-disable-next-line no-restricted-globals
-  return !isNaN(value) && isFinite(value) ? value : 20;
+  const value = parseInt(_value, 10);
+  return !Number.isNaN(value) && Number.isFinite(value) ? value : 20;
 };
 
 sanitizers.toPagingOffset = (_value) => {
-  const value = parseInt(_value);
-  // eslint-disable-next-line no-restricted-globals
-  return !isNaN(value) && isFinite(value) ? value : 0;
+  const value = parseInt(_value, 10);
+  return !Number.isNaN(value) && Number.isFinite(value) ? value : 0;
 };
 
 module.exports = sanitizers;

+ 1 - 1
bin/data-migrations/src/index.js

@@ -1,5 +1,5 @@
 
-/* eslint-disable no-undef, no-restricted-globals, regex/invalid, import/extensions */
+/* eslint-disable no-undef, regex/invalid, import/extensions */
 // ignore lint error because this file is js as mongoshell
 
 /**