Просмотр исходного кода

Revert "test ci"

This reverts commit 5157549392e83ec1278b30ee288bbee18b9c9e82.
Shun Miyazawa 2 лет назад
Родитель
Сommit
3a2ae1f9c6

+ 1 - 1
apps/app/src/components/Common/Dropdown/PageItemControl.test.tsx

@@ -6,7 +6,7 @@ import { PageItemControl } from './PageItemControl';
 
 describe('PageItemControl.tsx', () => {
   // TODO: https://redmine.weseek.co.jp/issues/138836 remove skip() after resolution
-  it('Should fire onClickRenameMenuItem() when clicking the rename button, with pageInfo.isDeletable being "false"', async() => {
+  it.skip('Should fire onClickRenameMenuItem() when clicking the rename button, with pageInfo.isDeletable being "false"', async() => {
     // setup
     const onClickRenameMenuItemMock = vi.fn();
 

+ 5 - 5
apps/app/src/components/Common/Dropdown/PageItemControl.tsx

@@ -87,10 +87,10 @@ const PageItemControlDropdownMenu = React.memo((props: DropdownMenuProps): JSX.E
       return;
     }
 
-    // if (!pageInfo?.isDeletable) {
-    //   logger.warn('This page could not be renamed.');
-    //   return;
-    // }
+    if (!pageInfo?.isDeletable) {
+      logger.warn('This page could not be renamed.');
+      return;
+    }
     await onClickRenameMenuItem(pageId, pageInfo);
   }, [onClickRenameMenuItem, pageId, pageInfo]);
 
@@ -181,7 +181,7 @@ const PageItemControlDropdownMenu = React.memo((props: DropdownMenuProps): JSX.E
         { !forceHideMenuItems?.includes(MenuItemType.RENAME) && isEnableActions && !isReadOnlyUser && (
           <DropdownItem
             onClick={renameItemClickedHandler}
-            // disabled={!pageInfo.isDeletable}
+            disabled={!pageInfo.isDeletable}
             data-testid="open-page-move-rename-modal-btn"
             className="grw-page-control-dropdown-item"
           >