Просмотр исходного кода

remove some eslint-disable lines

Yuki Takei 3 месяцев назад
Родитель
Сommit
36f29b2497

+ 0 - 1
apps/app/src/client/components/Admin/Common/AdminUpdateButtonRow.tsx

@@ -15,7 +15,6 @@ const AdminUpdateButtonRow = (props: Props): JSX.Element => {
       <div className="col-md-3"></div>
       <div className="col-md-9">
         <button
-          // eslint-disable-next-line react/button-has-type
           type={props.type ?? 'button'}
           className="btn btn-primary"
           onClick={props.onClick}

+ 0 - 1
apps/app/src/client/components/ReactMarkdownComponents/RichAttachment.tsx

@@ -92,7 +92,6 @@ export const RichAttachment = React.memo((props: RichAttachmentProps) => {
           <div className="ps-0">
             <div className="d-inline-block">
               {/* Since we need to include the "referer" to view the attachment on the shared page */}
-              {/* eslint-disable-next-line react/jsx-no-target-blank */}
               <a target="_blank" rel="noopener" href={filePathProxied}>
                 {attachmentName || originalName}
               </a>

+ 1 - 1
apps/app/src/migrations/20181019114028-abolish-page-group-relation.js

@@ -38,7 +38,7 @@ module.exports = {
       'pagegrouprelations',
     );
     if (!isPagegrouprelationsExists) {
-      logger.info("'pagegrouprelations' collection doesn't exist"); // eslint-disable-line
+      logger.info("'pagegrouprelations' collection doesn't exist");
       logger.info('Migration has successfully applied');
       return;
     }

+ 0 - 2
apps/app/src/server/crowi/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-this-alias */
-
 import next from 'next';
 import { createTerminus } from '@godaddy/terminus';
 import attachmentRoutes from '@growi/remark-attachment-refs/dist/server';

+ 1 - 1
apps/app/src/server/models/page.ts

@@ -558,7 +558,7 @@ export class PageQueryBuilder {
   }
 
   addConditionToPagenate(offset, limit, sortOpt?): PageQueryBuilder {
-    this.query = this.query.sort(sortOpt).skip(offset).limit(limit); // eslint-disable-line newline-per-chained-call
+    this.query = this.query.sort(sortOpt).skip(offset).limit(limit);
 
     return this;
   }

+ 0 - 2
apps/app/test/integration/service/external-user-group-sync.test.ts

@@ -288,7 +288,6 @@ describe('ExternalUserGroupSyncService.syncExternalUserGroups', () => {
       await configManager.updateConfigs(configParams);
     });
 
-    // eslint-disable-next-line jest/expect-expect
     it('syncs groups with new users', async () => {
       await testService.syncExternalUserGroups();
       await checkSync();
@@ -305,7 +304,6 @@ describe('ExternalUserGroupSyncService.syncExternalUserGroups', () => {
       await configManager.updateConfigs(configParams);
     });
 
-    // eslint-disable-next-line jest/expect-expect
     it('syncs groups without new users', async () => {
       await testService.syncExternalUserGroups();
       await checkSync(false);

+ 0 - 1
apps/slackbot-proxy/src/Server.ts

@@ -175,7 +175,6 @@ export class Server {
     }
     // use morgan
     else {
-      // eslint-disable-next-line @typescript-eslint/no-var-requires
       const morgan = require('morgan');
       this.app.use(morgan('dev'));
     }

+ 0 - 2
bin/github-actions/list-branches.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 /*
  * USAGE:
  *  node list-branches [OPTION]

+ 0 - 1
packages/remark-growi-directive/src/micromark-extension-growi-directive/lib/directive-leaf.js

@@ -21,7 +21,6 @@ const attributes = { tokenize: tokenizeAttributes, partial: true };
 
 /** @type {Tokenizer} */
 function tokenizeDirectiveLeaf(effects, ok, nok) {
-  // eslint-disable-next-line @typescript-eslint/no-this-alias
   const self = this;
 
   return start;

+ 0 - 1
packages/remark-growi-directive/src/micromark-extension-growi-directive/lib/directive-text.js

@@ -32,7 +32,6 @@ function previous(code) {
 
 /** @type {Tokenizer} */
 function tokenizeDirectiveText(effects, ok, nok) {
-  // eslint-disable-next-line @typescript-eslint/no-this-alias
   const self = this;
 
   return start;

+ 0 - 1
packages/remark-growi-directive/src/micromark-extension-growi-directive/lib/factory-name.js

@@ -15,7 +15,6 @@ import { codes } from 'micromark-util-symbol';
  * @param {string} type
  */
 export function factoryName(effects, ok, nok, type) {
-  // eslint-disable-next-line @typescript-eslint/no-this-alias
   const self = this;
 
   return start;