Browse Source

fix(slackbot): Stop auto-join to channels with middlewarer (#4424)

* unuse JoinToConversationMiddleware

* renive 'channels:join' scope from requiredScopes

* revert requiredScopes
Yuki Takei 4 years ago
parent
commit
3681775c8b
1 changed files with 1 additions and 2 deletions
  1. 1 2
      packages/slackbot-proxy/src/controllers/slack.ts

+ 1 - 2
packages/slackbot-proxy/src/controllers/slack.ts

@@ -26,7 +26,6 @@ import {
 } from '~/middlewares/slack-to-growi/authorizer';
 } from '~/middlewares/slack-to-growi/authorizer';
 import { UrlVerificationMiddleware } from '~/middlewares/slack-to-growi/url-verification';
 import { UrlVerificationMiddleware } from '~/middlewares/slack-to-growi/url-verification';
 import { ExtractGrowiUriFromReq } from '~/middlewares/slack-to-growi/extract-growi-uri-from-req';
 import { ExtractGrowiUriFromReq } from '~/middlewares/slack-to-growi/extract-growi-uri-from-req';
-import { JoinToConversationMiddleware } from '~/middlewares/slack-to-growi/join-to-conversation';
 import { InstallerService } from '~/services/InstallerService';
 import { InstallerService } from '~/services/InstallerService';
 import { SelectGrowiService } from '~/services/SelectGrowiService';
 import { SelectGrowiService } from '~/services/SelectGrowiService';
 import { RegisterService } from '~/services/RegisterService';
 import { RegisterService } from '~/services/RegisterService';
@@ -130,7 +129,7 @@ export class SlackCtrl {
 
 
 
 
   @Post('/commands')
   @Post('/commands')
-  @UseBefore(AddSigningSecretToReq, verifySlackRequest, AuthorizeCommandMiddleware, JoinToConversationMiddleware)
+  @UseBefore(AddSigningSecretToReq, verifySlackRequest, AuthorizeCommandMiddleware)
   async handleCommand(@Req() req: SlackOauthReq, @Res() res: Res): Promise<void|string|Res|WebAPICallResult> {
   async handleCommand(@Req() req: SlackOauthReq, @Res() res: Res): Promise<void|string|Res|WebAPICallResult> {
     const { body, authorizeResult } = req;
     const { body, authorizeResult } = req;