itizawa hace 4 años
padre
commit
32ff4f33c8

+ 4 - 5
packages/slackbot-proxy/src/controllers/growi-to-slack.ts

@@ -18,7 +18,7 @@ import { OrderRepository } from '~/repositories/order';
 
 
 import { InstallerService } from '~/services/InstallerService';
 import { InstallerService } from '~/services/InstallerService';
 import loggerFactory from '~/utils/logger';
 import loggerFactory from '~/utils/logger';
-import { DelegatorTypes, growiUriInjectorFactory } from '~/services/growi-uri-injector/GrowiUriInjectorFactory';
+import { findInjectorFactoryByType } from '~/services/growi-uri-injector/GrowiUriInjectorFactory';
 import { injectGrowiUriToView } from '~/utils/injectGrowiUriToView';
 import { injectGrowiUriToView } from '~/utils/injectGrowiUriToView';
 
 
 
 
@@ -179,11 +179,10 @@ export class GrowiToSlackCtrl {
           return;
           return;
         }
         }
         parsedBlock.elements.forEach((element) => {
         parsedBlock.elements.forEach((element) => {
-          if (!Object.values(DelegatorTypes).includes(element.type)) {
-            return;
+          const growiUriInjector = findInjectorFactoryByType(element.key);
+          if (growiUriInjector != null) {
+            growiUriInjector.inject(element, growiUri);
           }
           }
-          const growiUriInjector = growiUriInjectorFactory[element.type]();
-          growiUriInjector.inject(element, growiUri);
         });
         });
 
 
         return;
         return;

+ 7 - 0
packages/slackbot-proxy/src/services/growi-uri-injector/GrowiUriInjectorFactory.ts

@@ -14,3 +14,10 @@ export const growiUriInjectorFactory = {
     return new GrowiUriInjectionButtonDelegator();
     return new GrowiUriInjectionButtonDelegator();
   },
   },
 };
 };
+
+export const findInjectorFactoryByType = (type :DelegatorTypes): null|GrowiUriInjector => {
+  if (!Object.values(DelegatorTypes).includes(type)) {
+    return null;
+  }
+  return growiUriInjectorFactory[type]();
+};