Sfoglia il codice sorgente

Merge pull request #5859 from weseek/imprv/95203-remove-user-population

imprv: Remove user population
Shun Miyazawa 3 anni fa
parent
commit
32be9004fa

+ 0 - 1
packages/app/src/server/models/activity.ts

@@ -111,7 +111,6 @@ activitySchema.statics.getPaginatedActivity = async function(limit: number, offs
       limit,
       limit,
       offset,
       offset,
       sort: { createdAt: -1 },
       sort: { createdAt: -1 },
-      populate: 'user',
     },
     },
   );
   );
   return paginateResult;
   return paginateResult;

+ 1 - 15
packages/app/src/server/routes/apiv3/activity.ts

@@ -84,21 +84,7 @@ module.exports = (crowi: Crowi): Router => {
 
 
     try {
     try {
       const paginationResult = await Activity.getPaginatedActivity(limit, offset, query);
       const paginationResult = await Activity.getPaginatedActivity(limit, offset, query);
-
-      const User = crowi.model('User');
-      const serializedDocs = paginationResult.docs.map((doc: IActivity) => {
-        if (doc.user != null && doc.user instanceof User) {
-          doc.user = serializeUserSecurely(doc.user);
-        }
-        return doc;
-      });
-
-      const serializedPaginationResult = {
-        ...paginationResult,
-        docs: serializedDocs,
-      };
-
-      return res.apiv3({ serializedPaginationResult });
+      return res.apiv3({ paginationResult });
     }
     }
     catch (err) {
     catch (err) {
       logger.error('Failed to get paginated activity', err);
       logger.error('Failed to get paginated activity', err);

+ 1 - 1
packages/app/src/stores/activity.ts

@@ -16,6 +16,6 @@ export const useSWRxActivityList = (limit?: number, offset?: number, searchFilte
   return useSWRImmutable(
   return useSWRImmutable(
     ['/activity', limit, offset, stringifiedSearchFilter],
     ['/activity', limit, offset, stringifiedSearchFilter],
     (endpoint, limit, offset, stringifiedSearchFilter) => apiv3Get(endpoint, { limit, offset, searchFilter: stringifiedSearchFilter })
     (endpoint, limit, offset, stringifiedSearchFilter) => apiv3Get(endpoint, { limit, offset, searchFilter: stringifiedSearchFilter })
-      .then(result => result.data.serializedPaginationResult),
+      .then(result => result.data.paginationResult),
   );
   );
 };
 };