Explorar el Código

add TODO comments

Syunsuke Komma hace 3 años
padre
commit
2ddb4921a0

+ 1 - 0
packages/app/src/server/models/transfer-key.ts

@@ -24,6 +24,7 @@ const schema = new Schema<ITransferKey, TransferKeyModel, ITransferKeyMethods>({
   },
 });
 
+// TODO: validate createdAt
 schema.statics.findOneActiveTransferKey = async function(key: string): Promise<HydratedDocument<ITransferKey, ITransferKeyMethods> | null> {
   return this.findOne({ key });
 };

+ 2 - 0
packages/app/src/server/service/g2g-transfer.ts

@@ -168,6 +168,7 @@ export class G2GTransferPusherService implements Pusher {
   }
 
   public async canTransfer(toGROWIInfo: IDataGROWIInfo): Promise<boolean> {
+    // TODO: check FILE_UPLOAD_TOTAL_LIMIT, FILE_UPLOAD_DISABLED
     const configManager = this.crowi.configManager;
     const userUpperLimit = configManager.getConfig('crowi', 'security:userUpperLimit');
     const version = this.crowi.version;
@@ -373,6 +374,7 @@ export class G2GTransferReceiverService implements Receiver {
    * @returns
    */
   public async receiveAttachment(content: Readable, attachmentMap): Promise<void> {
+    // TODO: test with S3, local
     const { fileUploadService } = this.crowi;
     return fileUploadService.uploadFile(content, attachmentMap);
   }