Browse Source

wrap with useCallback

Kami-jo 3 years ago
parent
commit
2cfd49950a
1 changed files with 8 additions and 8 deletions
  1. 8 8
      packages/app/src/components/PageEditorByHackmd.jsx

+ 8 - 8
packages/app/src/components/PageEditorByHackmd.jsx

@@ -73,13 +73,13 @@ const PageEditorByHackmd = (props) => {
     return envVars.HACKMD_URI;
     return envVars.HACKMD_URI;
   }, [appContainer]);
   }, [appContainer]);
 
 
-  const isResume = () => {
+  const isResume = useCallback(() => {
     const {
     const {
       pageIdOnHackmd, hasDraftOnHackmd, isHackmdDraftUpdatingInRealtime,
       pageIdOnHackmd, hasDraftOnHackmd, isHackmdDraftUpdatingInRealtime,
     } = pageContainer.state;
     } = pageContainer.state;
     const isPageExistsOnHackmd = (pageIdOnHackmd != null);
     const isPageExistsOnHackmd = (pageIdOnHackmd != null);
     return (isPageExistsOnHackmd && hasDraftOnHackmd) || isHackmdDraftUpdatingInRealtime;
     return (isPageExistsOnHackmd && hasDraftOnHackmd) || isHackmdDraftUpdatingInRealtime;
-  };
+  }, [pageContainer.state]);
 
 
   const startToEdit = useCallback(async() => {
   const startToEdit = useCallback(async() => {
     const hackmdUri = getHackmdUri();
     const hackmdUri = getHackmdUri();
@@ -123,9 +123,9 @@ const PageEditorByHackmd = (props) => {
   /**
   /**
    * Start to edit w/o any api request
    * Start to edit w/o any api request
    */
    */
-  const resumeToEdit = () => {
+  const resumeToEdit = useCallback(() => {
     setIsInitialized(true);
     setIsInitialized(true);
-  };
+  }, []);
 
 
   const discardChanges = useCallback(async() => {
   const discardChanges = useCallback(async() => {
     const { pageId } = pageContainer.state;
     const { pageId } = pageContainer.state;
@@ -207,15 +207,15 @@ const PageEditorByHackmd = (props) => {
     }
     }
   }, [editorContainer, getHackmdUri, pageContainer.state.markdown, pageContainer.state.pageId]);
   }, [editorContainer, getHackmdUri, pageContainer.state.markdown, pageContainer.state.pageId]);
 
 
-  const penpalErrorOccuredHandler = (error) => {
+  const penpalErrorOccuredHandler = useCallback((error) => {
     pageContainer.showErrorToastr(error);
     pageContainer.showErrorToastr(error);
 
 
     setHasError(true);
     setHasError(true);
     setErrorMessage(t('hackmd.fail_to_connect'));
     setErrorMessage(t('hackmd.fail_to_connect'));
     setErrorReason(error.toString());
     setErrorReason(error.toString());
-  };
+  }, [pageContainer, t]);
 
 
-  const renderPreInitContent = () => {
+  const renderPreInitContent = useCallback(() => {
     const hackmdUri = getHackmdUri();
     const hackmdUri = getHackmdUri();
     const {
     const {
       revisionId, revisionIdHackmdSynced, remoteRevisionId, pageId,
       revisionId, revisionIdHackmdSynced, remoteRevisionId, pageId,
@@ -342,7 +342,7 @@ const PageEditorByHackmd = (props) => {
         {content}
         {content}
       </div>
       </div>
     );
     );
-  };
+  }, [discardChanges, getHackmdUri, isInitializing, isResume, pageContainer.state, resumeToEdit, startToEdit, t]);
 
 
   if (editorMode == null) {
   if (editorMode == null) {
     return null;
     return null;