Explorar o código

Merge pull request #3613 from weseek/imprv/gw5608-improve-bot-type-ui

Imprv/gw5608 improve bot type UI
itizawa %!s(int64=5) %!d(string=hai) anos
pai
achega
291c8d7815

BIN=BIN
public/images/slack-integration/impossible.png


BIN=BIN
public/images/slack-integration/possible.png


BIN=BIN
public/images/slack-integration/triangle-basic-gray.png


+ 0 - 3
resource/locales/en_US/admin/admin.json

@@ -264,9 +264,6 @@
       "without_proxy": "without proxy",
       "without_proxy": "without proxy",
       "with_proxy": "with proxy",
       "with_proxy": "with proxy",
       "recommended": "Recommended",
       "recommended": "Recommended",
-      "for_beginners": "- For beginners -",
-      "for_intermediate": "- For intermediates -",
-      "for_advanced": "- For advanced -",
       "set_up": "Set up",
       "set_up": "Set up",
       "multiple_workspaces_integration": "Multiple workspaces integration",
       "multiple_workspaces_integration": "Multiple workspaces integration",
       "security_control": "Security control",
       "security_control": "Security control",

+ 0 - 3
resource/locales/ja_JP/admin/admin.json

@@ -262,9 +262,6 @@
       "without_proxy": "without proxy",
       "without_proxy": "without proxy",
       "with_proxy": "with proxy",
       "with_proxy": "with proxy",
       "recommended": "おすすめ",
       "recommended": "おすすめ",
-      "for_beginners": "- 初心者向け -",
-      "for_intermediate": "- 中級者向け -",
-      "for_advanced": "- 上級者向け -",
       "set_up": "セットアップ",
       "set_up": "セットアップ",
       "multiple_workspaces_integration": "複数ワークスペースとの連携",
       "multiple_workspaces_integration": "複数ワークスペースとの連携",
       "security_control": "セキュリティコントロール",
       "security_control": "セキュリティコントロール",

+ 0 - 3
resource/locales/zh_CN/admin/admin.json

@@ -272,9 +272,6 @@
       "without_proxy": "without proxy",
       "without_proxy": "without proxy",
       "with_proxy": "with proxy",
       "with_proxy": "with proxy",
       "recommended": "受到推崇的",
       "recommended": "受到推崇的",
-      "for_beginners": "- 对于初学者 -",
-      "for_intermediate": "- 对于中级 -",
-      "for_advanced": "- 对于高级 -",
       "set_up": "设置",
       "set_up": "设置",
       "multiple_workspaces_integration": "集成到多个工作区",
       "multiple_workspaces_integration": "集成到多个工作区",
       "security_control": "安全控制",
       "security_control": "安全控制",

+ 17 - 21
src/client/js/components/Admin/SlackIntegration/SlackIntegration.jsx

@@ -106,7 +106,6 @@ const SlackIntegration = (props) => {
   const botTypes = {
   const botTypes = {
     officialBot: {
     officialBot: {
       name: t('admin:slack_integration.selecting_bot_types.official_bot'),
       name: t('admin:slack_integration.selecting_bot_types.official_bot'),
-      level: t('admin:slack_integration.selecting_bot_types.for_beginners'),
       setUp: 'easy',
       setUp: 'easy',
       multiWSIntegration: 'possible',
       multiWSIntegration: 'possible',
       securityControl: 'impossible',
       securityControl: 'impossible',
@@ -114,7 +113,6 @@ const SlackIntegration = (props) => {
     customBotWithoutProxy: {
     customBotWithoutProxy: {
       name: t('admin:slack_integration.selecting_bot_types.custom_bot'),
       name: t('admin:slack_integration.selecting_bot_types.custom_bot'),
       supplementaryBotName: t('admin:slack_integration.selecting_bot_types.without_proxy'),
       supplementaryBotName: t('admin:slack_integration.selecting_bot_types.without_proxy'),
-      level: t('admin:slack_integration.selecting_bot_types.for_intermediate'),
       setUp: 'normal',
       setUp: 'normal',
       multiWSIntegration: 'impossible',
       multiWSIntegration: 'impossible',
       securityControl: 'possible',
       securityControl: 'possible',
@@ -122,10 +120,9 @@ const SlackIntegration = (props) => {
     customBotWithProxy: {
     customBotWithProxy: {
       name: t('admin:slack_integration.selecting_bot_types.custom_bot'),
       name: t('admin:slack_integration.selecting_bot_types.custom_bot'),
       supplementaryBotName: t('admin:slack_integration.selecting_bot_types.with_proxy'),
       supplementaryBotName: t('admin:slack_integration.selecting_bot_types.with_proxy'),
-      level: t('admin:slack_integration.selecting_bot_types.for_advanced'),
       setUp: 'hard',
       setUp: 'hard',
       multiWSIntegration: 'possible',
       multiWSIntegration: 'possible',
-      securityControl: 'impossible',
+      securityControl: 'possible',
     },
     },
   };
   };
 
 
@@ -148,7 +145,10 @@ const SlackIntegration = (props) => {
             key={key}
             key={key}
           >
           >
             <div>
             <div>
-              <h3 className={`card-header mb-0 py-3 text-center ${currentBotType === `${key}` ? 'bg-primary text-light' : ''}`}>
+              <h3 className={`card-header mb-0 py-3
+              ${key === 'officialBot' ? 'd-flex align-items-center justify-content-center' : 'text-center'}
+              ${currentBotType === `${key}` ? 'bg-primary text-light' : ''}`}
+              >
                 <span className="mr-2">
                 <span className="mr-2">
                   {value.name}
                   {value.name}
 
 
@@ -164,29 +164,25 @@ const SlackIntegration = (props) => {
               </h3>
               </h3>
             </div>
             </div>
             <div className="card-body p-4">
             <div className="card-body p-4">
-              <p className="card-text">
-                <div className="text-center">
-                  {value.level}
-                </div>
-                <div className="my-4">
-                  <div className="d-flex justify-content-between mb-2">
-                    <span>{t('admin:slack_integration.selecting_bot_types.set_up')}</span>
-                    <span className={`bot-type-disc-${value.setUp}`}>{t(`admin:slack_integration.selecting_bot_types.${value.setUp}`)}</span>
+              <div className="card-text">
+                <div className="my-2">
+                  <div className="d-flex justify-content-between mb-3">
+                    {/* TODO add image of difficulties by GW-5638 */}
+                    {/* <span>{t('admin:slack_integration.selecting_bot_types.set_up')}</span> */}
+                    {/* <span className={`bot-type-disc-${value.setUp}`}>{t(`admin:slack_integration.selecting_bot_types.${value.setUp}`)}</span> */}
+
+
                   </div>
                   </div>
-                  <div className="d-flex justify-content-between mb-2">
+                  <div className="d-flex justify-content-between mb-3">
                     <span>{t('admin:slack_integration.selecting_bot_types.multiple_workspaces_integration')}</span>
                     <span>{t('admin:slack_integration.selecting_bot_types.multiple_workspaces_integration')}</span>
-                    <span className={`bot-type-disc-${value.multiWSIntegration}`}>
-                      {t(`admin:slack_integration.selecting_bot_types.${value.multiWSIntegration}`)}
-                    </span>
+                    <img className="bot-type-disc" src={`/images/slack-integration/${value.multiWSIntegration}.png`} alt="" />
                   </div>
                   </div>
                   <div className="d-flex justify-content-between">
                   <div className="d-flex justify-content-between">
                     <span>{t('admin:slack_integration.selecting_bot_types.security_control')}</span>
                     <span>{t('admin:slack_integration.selecting_bot_types.security_control')}</span>
-                    <span className={`bot-type-disc-${value.securityControl}`}>
-                      {t(`admin:slack_integration.selecting_bot_types.${value.securityControl}`)}
-                    </span>
+                    <img className="bot-type-disc" src={`/images/slack-integration/${value.securityControl}.png`} alt="" />
                   </div>
                   </div>
                 </div>
                 </div>
-              </p>
+              </div>
             </div>
             </div>
           </div>
           </div>
         );
         );

+ 2 - 14
src/client/styles/scss/theme/_apply-colors.scss

@@ -596,19 +596,7 @@ mark.rbt-highlight-text {
   Slack Integration
   Slack Integration
 */
 */
 .selecting-bot-type {
 .selecting-bot-type {
-  .bot-type-disc-easy {
-    color: #33d541;
-  }
-  .bot-type-disc-normal {
-    color: #e6a63c;
-  }
-  .bot-type-disc-hard {
-    color: #ff5757;
-  }
-  .bot-type-disc-possible {
-    color: $info;
-  }
-  .bot-type-disc-impossible {
-    color: $gray-500;
+  .bot-type-disc {
+    width: 20px;
   }
   }
 }
 }