Parcourir la source

refactor and add comment

Futa Arai il y a 2 ans
Parent
commit
26b08c25d3

+ 1 - 0
apps/app/src/components/PageEditor/PageEditor.tsx

@@ -187,6 +187,7 @@ export const PageEditor = React.memo((props: Props): JSX.Element => {
 
       // to sync revision id with page tree: https://github.com/weseek/growi/pull/7227
       mutatePageTree();
+      // sync current grant data after update
       mutateIsGrantNormalized();
 
       return page;

+ 1 - 5
apps/app/src/server/routes/apiv3/page/index.ts

@@ -579,10 +579,6 @@ module.exports = (crowi) => {
       return res.apiv3Err(new ErrorV3('Page is unreachable or empty.', 'page_unreachable_or_empty'), 400);
     }
 
-    const {
-      path, grant, grantedUsers, grantedGroups,
-    } = page;
-
     let isGrantNormalized = false;
     try {
       isGrantNormalized = await pageGrantService.isGrantNormalized(req.user, path, grant, grantedUsers, grantedGroups, false, false);
@@ -594,7 +590,7 @@ module.exports = (crowi) => {
 
     const currentPageGroupGrantData = await pageGrantService.getPageGroupGrantData(page, req.user);
     const currentPageGrant: IPageGrantData = {
-      grant,
+      grant: page.grant,
       groupGrantData: currentPageGroupGrantData,
     };