improved err handling

packages/slackbot-proxy/src/controllers/slack.ts

@@ -187,7 +187,11 @@ export class SlackCtrl {
 
     // register
     if (callBackId === 'register') {
-      await this.registerService.insertOrderRecord(this.orderRepository, installation, authorizeResult, payload);
+      const insertOrderResults = await this.registerService.insertOrderRecord(this.orderRepository, installation, authorizeResult, payload);
+      if (insertOrderResults != null && insertOrderResults.error != null) {
+        return;
+      }
+
       await this.registerService.notifyServerUriToSlack(authorizeResult, payload);
       return;
     }

packages/slackbot-proxy/src/services/RegisterService.ts

@@ -73,12 +73,14 @@ export class RegisterService implements GrowiCommandProcessor {
       });
     };
 
+    let url;
+
     try {
-      const url = new URL(growiUrl);
-      return url;
+      url = new URL(growiUrl);
     }
-    catch (err) {
+    catch (error) {
       postInvalidUrlErr();
+      return { error, growiUrl: url };
     }
 
     orderRepository.save({