Explorar el Código

imprv useEffect second arg

kaori hace 3 años
padre
commit
2415f83c0c
Se han modificado 1 ficheros con 2 adiciones y 4 borrados
  1. 2 4
      packages/app/src/pages/UnsavedAlertDialog.tsx

+ 2 - 4
packages/app/src/pages/UnsavedAlertDialog.tsx

@@ -36,8 +36,7 @@ const UnsavedAlertDialog = (): void => {
     return () => {
       window.removeEventListener('beforeunload', alertUnsavedWarningByBrowser);
     };
-  // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [alertUnsavedWarningByBrowser]);
 
 
   /*
@@ -49,8 +48,7 @@ const UnsavedAlertDialog = (): void => {
     return () => {
       router.events.off('routeChangeStart', alertUnsavedWarningByNextRouter);
     };
-  // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [alertUnsavedWarningByNextRouter, router.events]);
 
 
   return;