فهرست منبع

Merge pull request #9982 from weseek/fix-alert-autofix-569

fix: Potential fix for code scanning alert no. 569: Information exposure through a stack trace
mergify[bot] 11 ماه پیش
والد
کامیت
2214d3a87b

+ 3 - 1
packages/remark-lsx/src/server/routes/list-pages/index.spec.ts

@@ -128,7 +128,9 @@ describe('listPages', () => {
       expect(mocks.addNumConditionMock).toHaveBeenCalledOnce(); // throw an error
       expect(mocks.addSortConditionMock).not.toHaveBeenCalledOnce(); // does not called
       expect(resMock.status).toHaveBeenCalledOnce();
-      expect(resStatusMock.send).toHaveBeenCalledWith('error for test');
+      expect(resStatusMock.send).toHaveBeenCalledWith(
+        'An internal server error occurred.',
+      );
     });
 
     it('returns 400 HTTP response when the value is invalid', async () => {

+ 4 - 2
packages/remark-lsx/src/server/routes/list-pages/index.ts

@@ -92,7 +92,8 @@ export const listPages = async (
   try {
     toppageViewersCount = await getToppageViewersCount();
   } catch (error) {
-    return res.status(500).send(error);
+    console.error('Error occurred in getToppageViewersCount:', error);
+    return res.status(500).send('An internal server error occurred.');
   }
 
   let query = builder.query;
@@ -132,9 +133,10 @@ export const listPages = async (
     };
     return res.status(200).send(responseData);
   } catch (error) {
+    console.error('Error occurred while processing listPages request:', error);
     if (isHttpError(error)) {
       return res.status(error.status).send(error.message);
     }
-    return res.status(500).send(error.message);
+    return res.status(500).send('An internal server error occurred.');
   }
 };