Merge pull request #4250 from weseek/fix/checkPermissionForInteractions

Fix/check permission for interactions

packages/slackbot-proxy/src/services/RelationsService.ts

@@ -113,12 +113,12 @@ export class RelationsService {
       relation:Relation, channelName:string, callbackId:string, actionId:string,
   ):Promise<{isPermittedForInteractions:boolean, commandName:string}> {
 
-    let isPermittedForInteractions!:boolean;
-    let commandName!:string;
+    let isPermittedForInteractions = false;
+    let permissionForInteractions:boolean|string[];
 
     const singleUse = Object.keys(relation.permissionsForSingleUseCommands);
     const broadCastUse = Object.keys(relation.permissionsForBroadcastUseCommands);
-    let permissionForInteractions:boolean|string[];
+    let commandName!:string;
 
     [...singleUse, ...broadCastUse].forEach(async(tempCommandName) => {
 
@@ -142,7 +142,7 @@ export class RelationsService {
         return;
       }
       // check permission at channel level
-      if (Array.isArray(permissionForInteractions)) {
+      if (Array.isArray(permissionForInteractions) && permissionForInteractions.includes(channelName)) {
         isPermittedForInteractions = true;
         return;
       }