Просмотр исходного кода

change getActionUsers to useCallback function

WNomunomu 2 лет назад
Родитель
Сommit
1d7483b56f

+ 3 - 3
apps/app/src/components/InAppNotification/PageNotification/PageModelNotification.tsx

@@ -1,5 +1,5 @@
 import React, {
 import React, {
-  forwardRef, ForwardRefRenderFunction,
+  forwardRef, ForwardRefRenderFunction, useCallback,
 } from 'react';
 } from 'react';
 
 
 import type { IPage, HasObjectId } from '@growi/core';
 import type { IPage, HasObjectId } from '@growi/core';
@@ -25,7 +25,7 @@ const PageModelNotification: ForwardRefRenderFunction<IInAppNotificationOpenable
 
 
   const router = useRouter();
   const router = useRouter();
 
 
-  const getActionUsers = () => {
+  const getActionUsers = useCallback(() => {
     const latestActionUsers = notification.actionUsers.slice(0, 3);
     const latestActionUsers = notification.actionUsers.slice(0, 3);
     const latestUsers = latestActionUsers.map((user) => {
     const latestUsers = latestActionUsers.map((user) => {
       return `@${user.name}`;
       return `@${user.name}`;
@@ -44,7 +44,7 @@ const PageModelNotification: ForwardRefRenderFunction<IInAppNotificationOpenable
     }
     }
 
 
     return actionedUsers;
     return actionedUsers;
-  };
+  }, [notification.actionUsers]);
 
 
   const actionUsers = getActionUsers();
   const actionUsers = getActionUsers();