Просмотр исходного кода

remove unnecessary state defenition

kaori 3 лет назад
Родитель
Сommit
1d13613aa0

+ 1 - 9
packages/app/src/components/Page.jsx

@@ -197,14 +197,6 @@ const PageWrapper = (props) => {
   const { data: grantGroupId } = useSelectedGrantGroupId();
   const { data: grantGroupName } = useSelectedGrantGroupName();
 
-  const [slackChannelsStr, setSlackChannelsStr] = useState('');
-
-  useEffect(() => {
-    if (slackChannelsData != null) {
-      setSlackChannelsStr(slackChannelsData.toString());
-    }
-  }, [slackChannelsData]);
-
   if (currentPagePath == null || editorMode == null || isGuestUser == null) {
     return null;
   }
@@ -218,7 +210,7 @@ const PageWrapper = (props) => {
       isGuestUser={isGuestUser}
       isMobile={isMobile}
       isSlackEnabled={isSlackEnabled || false}
-      slackChannels={slackChannelsStr}
+      slackChannels={slackChannelsData?.toString() || ''}
       grant={grant}
       grantGroupId={grantGroupId}
       grantGroupName={grantGroupName}

+ 1 - 9
packages/app/src/components/PageEditor.jsx

@@ -417,14 +417,6 @@ const PageEditorWrapper = (props) => {
   const { data: isIndentSizeForced } = useIsIndentSizeForced();
   const { data: indentSize, mutate: mutateCurrentIndentSize } = useCurrentIndentSize();
 
-  const [slackChannelsStr, setSlackChannelsStr] = useState('');
-
-  useEffect(() => {
-    if (slackChannelsData != null) {
-      setSlackChannelsStr(slackChannelsData.toString());
-    }
-  }, [slackChannelsData]);
-
   if (isEditable == null || editorMode == null) {
     return null;
   }
@@ -436,7 +428,7 @@ const PageEditorWrapper = (props) => {
       editorMode={editorMode}
       isMobile={isMobile}
       isSlackEnabled={isSlackEnabled || false}
-      slackChannels={slackChannelsStr}
+      slackChannels={slackChannelsData?.toString() || ''}
       grant={grant}
       grantGroupId={grantGroupId}
       grantGroupName={grantGroupName}

+ 1 - 9
packages/app/src/components/PageEditorByHackmd.jsx

@@ -436,14 +436,6 @@ const PageEditorByHackmdWrapper = (props) => {
   const { data: grantGroupId } = useSelectedGrantGroupId();
   const { data: grantGroupName } = useSelectedGrantGroupName();
 
-  const [slackChannelsStr, setSlackChannelsStr] = useState('');
-
-  useEffect(() => {
-    if (slackChannelsData != null) {
-      setSlackChannelsStr(slackChannelsData.toString());
-    }
-  }, [slackChannelsData]);
-
   if (editorMode == null) {
     return null;
   }
@@ -453,7 +445,7 @@ const PageEditorByHackmdWrapper = (props) => {
       {...props}
       editorMode={editorMode}
       isSlackEnabled={isSlackEnabled || false}
-      slackChannels={slackChannelsStr}
+      slackChannels={slackChannelsData?.toString() || ''}
       grant={grant}
       grantGroupId={grantGroupId}
       grantGroupName={grantGroupName}