Browse Source

update useCallback arguments

Yuki Takei 4 years ago
parent
commit
1334de6311
1 changed files with 7 additions and 7 deletions
  1. 7 7
      packages/app/src/components/Sidebar.tsx

+ 7 - 7
packages/app/src/components/Sidebar.tsx

@@ -29,7 +29,7 @@ const GlobalNavigation = () => {
     else {
     else {
       mutateSidebarCollapsed(false);
       mutateSidebarCollapsed(false);
     }
     }
-  }, [currentContents, isCollapsed]);
+  }, [currentContents, isCollapsed, mutateSidebarCollapsed]);
 
 
   return <SidebarNav onItemSelected={itemSelectedHandler} />;
   return <SidebarNav onItemSelected={itemSelectedHandler} />;
 };
 };
@@ -152,7 +152,7 @@ const Sidebar = (props: Props) => {
       //   navigationUIController.setState({ productNavWidth: this.sidebarWidthCached });
       //   navigationUIController.setState({ productNavWidth: this.sidebarWidthCached });
       // }
       // }
     }
     }
-  }, [isResizeDisabled]);
+  }, [isResizeDisabled, mutateSidebarResizeDisabled]);
 
 
   // addCssClassTemporary(className) {
   // addCssClassTemporary(className) {
   //   // clear
   //   // clear
@@ -203,11 +203,11 @@ const Sidebar = (props: Props) => {
     if (!isHover) {
     if (!isHover) {
       setContentWidth(sidebarMinimizeWidth);
       setContentWidth(sidebarMinimizeWidth);
     }
     }
-  }, [isCollapsed, isDrawerMode, currentProductNavWidth]);
+  }, [isCollapsed, isDrawerMode, setContentWidth, currentProductNavWidth]);
 
 
   const toggleNavigationBtnClickHandler = useCallback(() => {
   const toggleNavigationBtnClickHandler = useCallback(() => {
     mutateSidebarCollapsed(!isCollapsed);
     mutateSidebarCollapsed(!isCollapsed);
-  }, [isCollapsed]);
+  }, [isCollapsed, mutateSidebarCollapsed]);
 
 
   useEffect(() => {
   useEffect(() => {
     if (isCollapsed) {
     if (isCollapsed) {
@@ -216,7 +216,7 @@ const Sidebar = (props: Props) => {
     else {
     else {
       setContentWidth(currentProductNavWidth);
       setContentWidth(currentProductNavWidth);
     }
     }
-  }, [isCollapsed]);
+  }, [currentProductNavWidth, isCollapsed, setContentWidth]);
 
 
   const draggableAreaMoveHandler = useCallback((event) => {
   const draggableAreaMoveHandler = useCallback((event) => {
     if (isDragging) {
     if (isDragging) {
@@ -227,7 +227,7 @@ const Sidebar = (props: Props) => {
         resizableContainer.current.classList.add('dragging');
         resizableContainer.current.classList.add('dragging');
       }
       }
     }
     }
-  }, [isDragging]);
+  }, [isDragging, setContentWidth]);
 
 
   const dragableAreaMouseUpHandler = useCallback(() => {
   const dragableAreaMouseUpHandler = useCallback(() => {
     if (resizableContainer.current == null) {
     if (resizableContainer.current == null) {
@@ -252,7 +252,7 @@ const Sidebar = (props: Props) => {
     document.removeEventListener('mousemove', draggableAreaMoveHandler);
     document.removeEventListener('mousemove', draggableAreaMoveHandler);
     document.removeEventListener('mouseup', dragableAreaMouseUpHandler);
     document.removeEventListener('mouseup', dragableAreaMouseUpHandler);
 
 
-  }, [draggableAreaMoveHandler]);
+  }, [draggableAreaMoveHandler, mutateProductNavWidth, mutateSidebarCollapsed]);
 
 
   const dragableAreaClickHandler = useCallback(() => {
   const dragableAreaClickHandler = useCallback(() => {
     if (isCollapsed || isDrawerMode) {
     if (isCollapsed || isDrawerMode) {