Merge branch 'master' into support/use-eslint-autofixonsave

# Conflicts:
#	src/server/routes/page.js

CHANGES.md

@@ -3,7 +3,8 @@ CHANGES
 
 ## 3.4.2-RC
 
-* 
+* Fix: Nofitication to Slack doesn't work
+    * Introduced by 3.4.0
 
 ## 3.4.1
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "growi",
-  "version": "3.4.2-RC",
+  "version": "3.4.3-RC",
   "description": "Team collaboration software using markdown",
   "tags": [
     "wiki",

src/server/routes/page.js

@@ -95,6 +95,7 @@ module.exports = function(crowi, app) {
 
     if (crowi.slack) {
       const promises = slackChannels.split(',').map((chan) => {
+        logger.debug('crowi.slack is exist', crowi.slack);
         return crowi.slack.postPage(page, user, chan, updateOrCreate, previousRevision);
       });
 

src/server/util/slack.js

@@ -123,7 +123,7 @@ module.exports = function(crowi) {
       author_link: urljoin(url, 'user', user.username),
       author_icon: user.image,
       title: page.path,
-      title_link: urljoin(url, page._id),
+      title_link: urljoin(url, page.id),
       text: body,
       mrkdwn_in: ['text'],
     };