Merge pull request #10324 from growilabs/fix/lint-error

fix: lint error

apps/app/bin/print-memory-consumption.ts

@@ -55,7 +55,10 @@ class NodeMemoryConsumptionChecker {
   }
 
   // Helper method to get pressure status and icon
-  private getPressureInfo(percentage: number): { status: string; icon: string } {
+  private getPressureInfo(percentage: number): {
+    status: string;
+    icon: string;
+  } {
     if (percentage > 90) return { status: 'HIGH PRESSURE', icon: '🔴' };
     if (percentage > 70) return { status: 'MODERATE PRESSURE', icon: '🟡' };
     return { status: 'LOW PRESSURE', icon: '🟢' };
@@ -71,9 +74,13 @@ class NodeMemoryConsumptionChecker {
     return new Promise((resolve, reject) => {
       get(url, (res) => {
         let data = '';
-        res.on('data', (chunk) => { data += chunk; });
+        res.on('data', (chunk) => {
+          data += chunk;
+        });
         res.on('end', () => resolve(data));
-      }).on('error', (err) => reject(this.createError(`Cannot connect to ${url}: ${err.message}`)));
+      }).on('error', (err) =>
+        reject(this.createError(`Cannot connect to ${url}: ${err.message}`)),
+      );
     });
   }
 
@@ -218,9 +225,20 @@ class NodeMemoryConsumptionChecker {
       return;
     }
 
-    const [heapUsedMB, heapTotalMB, heapLimitMB, rssMB, externalMB, arrayBuffersMB] = [
-      this.toMB(info.heapUsed), this.toMB(info.heapTotal), this.toMB(info.heapLimit || 0),
-      this.toMB(info.rss), this.toMB(info.external), this.toMB(info.arrayBuffers)
+    const [
+      heapUsedMB,
+      heapTotalMB,
+      heapLimitMB,
+      rssMB,
+      externalMB,
+      arrayBuffersMB,
+    ] = [
+      this.toMB(info.heapUsed),
+      this.toMB(info.heapTotal),
+      this.toMB(info.heapLimit || 0),
+      this.toMB(info.rss),
+      this.toMB(info.external),
+      this.toMB(info.arrayBuffers),
     ];
 
     console.log('\n📊 Node.js Memory Information');
@@ -237,20 +255,35 @@ class NodeMemoryConsumptionChecker {
     // Heap Limits
     console.log('\n🔸 Heap Limits:');
     if (info.heapLimit) {
-      const limitType = info.heapLimitSource === 'explicit' ? 'Explicit Limit' : 'Default Limit';
-      const limitSource = info.heapLimitSource === 'explicit' ? '(from --max-old-space-size)' : '(system default)';
-      console.log(`  ${limitType}: ${heapLimitMB.toFixed(2)} MB ${limitSource}`);
-      console.log(`  Global Usage:   ${((heapUsedMB / heapLimitMB) * 100).toFixed(2)}% of maximum`);
+      const limitType =
+        info.heapLimitSource === 'explicit'
+          ? 'Explicit Limit'
+          : 'Default Limit';
+      const limitSource =
+        info.heapLimitSource === 'explicit'
+          ? '(from --max-old-space-size)'
+          : '(system default)';
+      console.log(
+        `  ${limitType}: ${heapLimitMB.toFixed(2)} MB ${limitSource}`,
+      );
+      console.log(
+        `  Global Usage:   ${((heapUsedMB / heapLimitMB) * 100).toFixed(2)}% of maximum`,
+      );
     }
 
     // Heap Pressure Analysis
     const heapPressure = (info.heapUsed / info.heapTotal) * 100;
-    const { status: pressureStatus, icon: pressureIcon } = this.getPressureInfo(heapPressure);
+    const { status: pressureStatus, icon: pressureIcon } =
+      this.getPressureInfo(heapPressure);
     console.log('\n� Memory Pressure Analysis:');
-    console.log(`  Current Pool:   ${pressureIcon} ${pressureStatus} (${heapPressure.toFixed(1)}% of allocated heap)`);
+    console.log(
+      `  Current Pool:   ${pressureIcon} ${pressureStatus} (${heapPressure.toFixed(1)}% of allocated heap)`,
+    );
 
     if (heapPressure > 90) {
-      console.log('  📝 Note: High pressure is normal - Node.js will allocate more heap as needed');
+      console.log(
+        '  📝 Note: High pressure is normal - Node.js will allocate more heap as needed',
+      );
     }
 
     // System Information
@@ -271,10 +304,13 @@ class NodeMemoryConsumptionChecker {
     console.log('\n📋 Summary:');
     if (info.heapLimit) {
       const heapUsagePercent = (heapUsedMB / heapLimitMB) * 100;
-      console.log(`Heap Memory: ${heapUsedMB.toFixed(2)} MB / ${heapLimitMB.toFixed(2)} MB (${heapUsagePercent.toFixed(2)}%)`);
-      console.log(heapUsagePercent > 80
-        ? '⚠️  Consider increasing heap limit with --max-old-space-size if needed'
-        : '✅ Memory usage is within healthy limits'
+      console.log(
+        `Heap Memory: ${heapUsedMB.toFixed(2)} MB / ${heapLimitMB.toFixed(2)} MB (${heapUsagePercent.toFixed(2)}%)`,
+      );
+      console.log(
+        heapUsagePercent > 80
+          ? '⚠️  Consider increasing heap limit with --max-old-space-size if needed'
+          : '✅ Memory usage is within healthy limits',
       );
     }
 

apps/app/src/features/external-user-group/client/components/ExternalUserGroup/ExternalUserGroupManagement.tsx

@@ -153,7 +153,7 @@ export const ExternalGroupManagement: FC = () => {
         hideDeleteModal();
 
         toastSuccess(`Deleted ${selectedExternalUserGroup?.name} group.`);
-      } catch (err) {
+      } catch {
         toastError(new Error('Unable to delete the groups'));
       }
     },

apps/app/src/features/external-user-group/server/models/external-user-group-relation.ts

@@ -15,6 +15,7 @@ export interface ExternalUserGroupRelationDocument
 
 export interface ExternalUserGroupRelationModel
   extends Model<ExternalUserGroupRelationDocument> {
+  // biome-ignore lint/suspicious/noExplicitAny: ignore
   [x: string]: any; // for old methods
 
   PAGE_ITEMS: 50;

apps/app/src/features/external-user-group/server/models/external-user-group.ts

@@ -12,6 +12,7 @@ export interface ExternalUserGroupDocument
 
 export interface ExternalUserGroupModel
   extends Model<ExternalUserGroupDocument> {
+  // biome-ignore lint/suspicious/noExplicitAny: ignore
   [x: string]: any; // for old methods
 
   PAGE_ITEMS: 10;

packages/presentation/src/client/components/GrowiSlides.tsx

@@ -30,7 +30,7 @@ export const GrowiSlides = (props: Props): JSX.Element => {
     rendererOptions.remarkPlugins == null ||
     rendererOptions.components == null
   ) {
-    return <></>;
+    return;
   }
 
   rendererOptions.remarkPlugins.push([

packages/presentation/src/client/services/renderer/extract-sections.ts

@@ -61,7 +61,7 @@ export const remarkPlugin: Plugin<[ExtractSectionsPluginParams]> = (
 
   return (tree) => {
     // wrap with <section>
-    visit(tree, startCondition, (node, index, parent: Parent) => {
+    visit(tree, startCondition, (node, _index, parent: Parent) => {
       if (parent == null || parent.type !== 'root' || node.type === 'yaml') {
         return;
       }

packages/remark-attachment-refs/src/client/components/ExtractedAttachments.tsx

@@ -107,7 +107,7 @@ export const ExtractedAttachments = React.memo(
 
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     const renderExtractedImage = useCallback(
-      (attachment: IAttachmentHasId, index: number) => {
+      (attachment: IAttachmentHasId, _index: number) => {
         const { options } = refsContext;
 
         // determine alt

packages/remark-attachment-refs/src/server/routes/refs.ts

@@ -62,7 +62,7 @@ function addDepthCondition(query, pagePath, optionsDepth) {
 
 type RequestWithUser = Request & { user: HydratedDocument<IUser> };
 
-const loginRequiredFallback = (req, res) => {
+const loginRequiredFallback = (_req, res) => {
   return res.status(403).send('login required');
 };
 
@@ -203,7 +203,7 @@ export const routesFactory = (crowi): any => {
 
         try {
           regex = generateRegexp(regexOptionValue);
-        } catch (err) {
+        } catch {
           res.status(400).send("the 'regex' option is invalid as RegExp.");
           return;
         }

packages/remark-drawio/src/components/DrawioViewer.tsx

@@ -162,7 +162,7 @@ export const DrawioViewer = memo((props: DrawioViewerProps): JSX.Element => {
     }
 
     const observer = new ResizeObserver((entries) => {
-      for (const entry of entries) {
+      for (const _entry of entries) {
         // setElementWidth(entry.contentRect.width);
         onRenderingStart?.();
         renderDrawioWithDebounce();

packages/remark-growi-directive/src/mdast-util-growi-directive/lib/index.js

@@ -22,8 +22,6 @@ import { stringifyEntitiesLight } from 'stringify-entities';
 
 const own = {}.hasOwnProperty;
 
-const shortcut = /^[^\t\n\r "#'.<=>`}]+$/;
-
 export const DirectiveType = Object.freeze({
   Text: 'textGrowiPluginDirective',
   Leaf: 'leafGrowiPluginDirective',
@@ -223,12 +221,6 @@ function attributes(node, state) {
   const attrs = node.attributes || {};
   /** @type {Array.<string>} */
   const values = [];
-  /** @type {string|undefined} */
-  let classesFull;
-  /** @type {string|undefined} */
-  let classes;
-  /** @type {string|undefined} */
-  let id;
   /** @type {string} */
   let key;
 

packages/remark-growi-directive/src/micromark-extension-growi-directive/lib/factory-attributes.js

@@ -50,8 +50,6 @@ export function factoryAttributes(
   attributeValueData,
   disallowEol,
 ) {
-  /** @type {string} */
-  let type;
   /** @type {Code|undefined} */
   let marker;
 

packages/remark-lsx/src/client/components/Lsx.tsx

@@ -93,7 +93,7 @@ const LsxSubstance = React.memo(
 
     const contents = useMemo(() => {
       if (data == null) {
-        return <></>;
+        return;
       }
 
       const depthRange = lsxContext.getOptDepth();

packages/remark-lsx/src/server/index.ts

@@ -5,7 +5,7 @@ import { FilterXSS } from 'xss';
 import type { LsxApiOptions } from '../interfaces/api';
 import { listPages } from './routes/list-pages';
 
-const loginRequiredFallback = (req: Request, res: Response) => {
+const loginRequiredFallback = (_req: Request, res: Response) => {
   return res.status(403).send('login required');
 };
 

packages/slack/src/middlewares/parse-slack-interaction-request.ts

@@ -5,7 +5,7 @@ import { InteractionPayloadAccessor } from '../utils/interaction-payload-accesso
 
 export const parseSlackInteractionRequest = (
   req: RequestFromSlack,
-  res: Response,
+  _res: Response,
   next: NextFunction,
 ): void => {
   // There is no payload in the request from slack

packages/slack/src/middlewares/verify-growi-to-slack-request.ts

@@ -14,7 +14,7 @@ const logger = loggerFactory(
  */
 export const verifyGrowiToSlackRequest = (
   req: RequestFromGrowi,
-  res: Response,
+  _res: Response,
   next: NextFunction,
 ): void => {
   const str = req.headers['x-growi-gtop-tokens'];

packages/slack/src/middlewares/verify-slack-request.ts

@@ -16,7 +16,7 @@ const logger = loggerFactory('@growi/slack:middlewares:verify-slack-request');
 export const verifySlackRequest = (
   // biome-ignore lint/suspicious/noExplicitAny: ignore
   req: RequestFromSlack & { rawBody: any },
-  res: Response,
+  _res: Response,
   next: NextFunction,
 ): void => {
   const signingSecret = req.slackSigningSecret;
@@ -40,7 +40,7 @@ export const verifySlackRequest = (
   }
 
   // protect against replay attacks
-  const time = Math.floor(new Date().getTime() / 1000);
+  const time = Math.floor(Date.now() / 1000);
   if (Math.abs(time - timestamp) > 300) {
     const message = 'Verification failed.';
     logger.warn(message, { body: req.body });

packages/slack/src/utils/block-kit-builder.ts

@@ -1,5 +1,4 @@
 import type {
-  Action,
   ActionsBlock,
   ActionsBlockElement,
   Button,
@@ -10,7 +9,6 @@ import type {
   InputBlock,
   MultiSelect,
   Option,
-  Overflow,
   PlainTextInput,
   RadioButtons,
   SectionBlock,

packages/slack/src/utils/response-url-validator.ts

@@ -36,7 +36,7 @@ export function isValidResponseUrl(
     }
 
     return false;
-  } catch (error) {
+  } catch {
     // Invalid URL format
     return false;
   }

packages/ui/src/components/PagePath/PageListMeta.tsx

@@ -18,6 +18,7 @@ const SeenUsersCount = (props: SeenUsersCountProps): JSX.Element => {
   const { count, shouldSpaceOutIcon, basisViewersCount } = props;
 
   if (count === 0) {
+    // biome-ignore lint/complexity/noUselessFragments: ignore
     return <></>;
   }
 
@@ -25,6 +26,7 @@ const SeenUsersCount = (props: SeenUsersCountProps): JSX.Element => {
     basisViewersCount != null &&
     basisViewersCount <= SEEN_USERS_HIDE_THRES__ACTIVE_USERS_COUNT
   ) {
+    // biome-ignore lint/complexity/noUselessFragments: ignore
     return <></>;
   }
 
@@ -35,6 +37,7 @@ const SeenUsersCount = (props: SeenUsersCountProps): JSX.Element => {
   );
 
   if (strengthLevel > MAX_STRENGTH_LEVEL) {
+    // biome-ignore lint/complexity/noUselessFragments: ignore
     return <></>;
   }
 

packages/ui/src/components/PagePath/PagePathLabel.tsx

@@ -14,7 +14,7 @@ const TextElement: FC<TextElemProps> = (props: TextElemProps) => (
         dangerouslySetInnerHTML={{ __html: props.children?.toString() || '' }}
       />
     ) : (
-      <>{props.children}</>
+      props.children
     )}
   </>
 );
@@ -48,6 +48,7 @@ export const PagePathLabel: FC<Props> = (props: Props) => {
     );
   } else if (isFormerOnly) {
     textElem = dPagePath.isFormerRoot ? (
+      // biome-ignore lint/complexity/noUselessFragments: ignore
       <>/</>
     ) : (
       <TextElement isHTML={isPathIncludedHtml}>{dPagePath.former}</TextElement>

packages/ui/src/components/UserPicture.tsx

@@ -1,6 +1,7 @@
 import type { IUser, Ref } from '@growi/core';
 import { pagePathUtils } from '@growi/core/dist/utils';
 import dynamic from 'next/dynamic';
+import Image from 'next/image';
 import { useRouter } from 'next/router';
 import {
   forwardRef,
@@ -181,7 +182,9 @@ export const UserPicture = memo((userProps: Props): JSX.Element => {
     .filter(Boolean)
     .join(' ');
 
-  const imgElement = <img src={src} alt={displayName} className={className} />;
+  const imgElement = (
+    <Image src={src} alt={displayName} className={className} />
+  );
   const baseProps = { displayName, size, children: imgElement };
 
   if (username == null || noLink) {