tidy up constructor args and fix bug for generateRespondUtil

apps/app/src/server/routes/apiv3/slack-integration.js

@@ -221,7 +221,7 @@ module.exports = (crowi) => {
       throw SlackCommandHandlerError('App site url must exist.');
     }
 
-    return generateRespondUtil(responseUrl, proxyUri, appSiteUrl);
+    return generateRespondUtil({ responseUrl, proxyUri, appSiteUrl });
   }
 
   function getGrowiCommand(body) {

packages/slack/src/utils/respond-util-factory.ts

@@ -28,12 +28,18 @@ function getUrl(responseUrl: string, proxyUri?: string): string {
   return finalUrl;
 }
 
+type RespondUtilConstructorArgs = {
+  responseUrl: string;
+  appSiteUrl: string;
+  proxyUri?: string;
+};
+
 export class RespondUtil implements IRespondUtil {
   url!: string;
 
   options!: AxiosOptions;
 
-  constructor(responseUrl: string, appSiteUrl: string, proxyUri?: string) {
+  constructor({ responseUrl, appSiteUrl, proxyUri }: RespondUtilConstructorArgs) {
     this.url = getUrl(responseUrl, proxyUri);
 
     this.options = {
@@ -91,10 +97,6 @@ export class RespondUtil implements IRespondUtil {
   }
 }
 
-export function generateRespondUtil(
-  responseUrl: string,
-  appSiteUrl: string,
-  proxyUri?: string,
-): RespondUtil {
-  return new RespondUtil(responseUrl, appSiteUrl, proxyUri);
+export function generateRespondUtil(args: RespondUtilConstructorArgs): RespondUtil {
+  return new RespondUtil(args);
 }