refactor: Use mongodb-connection-string-url for robust URI parsing

- Add mongodb-connection-string-url package dependency
- Replace custom URI parsing logic with official MongoDB package
- Add comprehensive unit tests for replaceMongoDbName function
- Simplify code from 47 lines to 22 lines (~53% reduction)
- Better handling of edge cases (URL-encoded passwords, IPv6, etc.)
- Improves protocol validation (now rejects non-MongoDB protocols)

Co-authored-by: yuki-takei <1638767+yuki-takei@users.noreply.github.com>

apps/app/package.json

@@ -163,6 +163,7 @@
     "migrate-mongo": "^11.0.0",
     "mkdirp": "^1.0.3",
     "mongodb": "^4.17.2",
+    "mongodb-connection-string-url": "^3.0.1",
     "mongoose": "^6.13.6",
     "mongoose-gridfs": "^1.3.0",
     "mongoose-paginate-v2": "^1.3.9",

apps/app/test/setup/mongoms.spec.ts

@@ -0,0 +1,109 @@
+import ConnectionString from 'mongodb-connection-string-url';
+import { describe, expect, it } from 'vitest';
+
+/**
+ * Replace the database name in a MongoDB connection URI.
+ * Uses mongodb-connection-string-url package for robust parsing.
+ */
+function replaceMongoDbName(uri: string, newDbName: string): string {
+  const cs = new ConnectionString(uri);
+  cs.pathname = `/${newDbName}`;
+  return cs.href;
+}
+
+describe('replaceMongoDbName', () => {
+  describe('single-host URIs', () => {
+    it('should replace database name in basic URI', () => {
+      const result = replaceMongoDbName('mongodb://localhost:27017/growi_test', 'new_db');
+      expect(result).toBe('mongodb://localhost:27017/new_db');
+    });
+
+    it('should add database name when URI has no database', () => {
+      const result = replaceMongoDbName('mongodb://localhost:27017', 'new_db');
+      expect(result).toBe('mongodb://localhost:27017/new_db');
+    });
+
+    it('should add database name when URI ends with slash', () => {
+      const result = replaceMongoDbName('mongodb://localhost:27017/', 'new_db');
+      expect(result).toBe('mongodb://localhost:27017/new_db');
+    });
+
+    it('should preserve query parameters', () => {
+      const result = replaceMongoDbName('mongodb://localhost:27017?param=value', 'new_db');
+      expect(result).toBe('mongodb://localhost:27017/new_db?param=value');
+    });
+
+    it('should replace database name and preserve query parameters', () => {
+      const result = replaceMongoDbName('mongodb://localhost:27017/growi_test?param=value', 'new_db');
+      expect(result).toBe('mongodb://localhost:27017/new_db?param=value');
+    });
+
+    it('should handle authentication credentials', () => {
+      const result = replaceMongoDbName('mongodb://user:pass@localhost:27017/growi_test', 'new_db');
+      expect(result).toBe('mongodb://user:pass@localhost:27017/new_db');
+    });
+
+    it('should handle authentication credentials with query parameters', () => {
+      const result = replaceMongoDbName('mongodb://user:pass@localhost:27017/growi_test?authSource=admin', 'new_db');
+      expect(result).toBe('mongodb://user:pass@localhost:27017/new_db?authSource=admin');
+    });
+
+    it('should handle URL-encoded credentials', () => {
+      const result = replaceMongoDbName('mongodb://user%40name:p%40ss@localhost:27017/growi_test', 'new_db');
+      expect(result).toBe('mongodb://user%40name:p%40ss@localhost:27017/new_db');
+    });
+  });
+
+  describe('replica set URIs (multiple hosts)', () => {
+    it('should replace database name in replica set URI', () => {
+      const result = replaceMongoDbName('mongodb://host1:27017,host2:27017/growi_test?replicaSet=rs0', 'new_db');
+      expect(result).toBe('mongodb://host1:27017,host2:27017/new_db?replicaSet=rs0');
+    });
+
+    it('should add database name to replica set URI without database', () => {
+      const result = replaceMongoDbName('mongodb://host1:27017,host2:27017,host3:27017?replicaSet=rs0', 'new_db');
+      expect(result).toBe('mongodb://host1:27017,host2:27017,host3:27017/new_db?replicaSet=rs0');
+    });
+
+    it('should handle replica set URI with authentication', () => {
+      const result = replaceMongoDbName('mongodb://user:pass@host1:27017,host2:27017/growi_test?replicaSet=rs0', 'new_db');
+      expect(result).toBe('mongodb://user:pass@host1:27017,host2:27017/new_db?replicaSet=rs0');
+    });
+
+    it('should handle replica set URI without query parameters', () => {
+      const result = replaceMongoDbName('mongodb://host1:27017,host2:27017/growi_test', 'new_db');
+      expect(result).toBe('mongodb://host1:27017,host2:27017/new_db');
+    });
+  });
+
+  describe('edge cases', () => {
+    it('should handle different database names', () => {
+      const result = replaceMongoDbName('mongodb://localhost:27017/growi_test', 'growi_test_1');
+      expect(result).toBe('mongodb://localhost:27017/growi_test_1');
+    });
+
+    it('should handle database names with underscores and numbers', () => {
+      const result = replaceMongoDbName('mongodb://localhost:27017/old_db_123', 'new_db_456');
+      expect(result).toBe('mongodb://localhost:27017/new_db_456');
+    });
+
+    it('should preserve all query parameters', () => {
+      const result = replaceMongoDbName(
+        'mongodb://localhost:27017/growi_test?authSource=admin&retryWrites=true&w=majority',
+        'new_db'
+      );
+      expect(result).toBe('mongodb://localhost:27017/new_db?authSource=admin&retryWrites=true&w=majority');
+    });
+  });
+
+  describe('error handling', () => {
+    it('should throw error for invalid URI protocol', () => {
+      // mongodb-connection-string-url validates protocol
+      expect(() => replaceMongoDbName('http://localhost:27017/db', 'new_db')).toThrow();
+    });
+
+    it('should throw error for malformed URI', () => {
+      expect(() => replaceMongoDbName('not-a-uri', 'new_db')).toThrow();
+    });
+  });
+});

apps/app/test/setup/mongoms.ts

@@ -1,3 +1,4 @@
+import ConnectionString from 'mongodb-connection-string-url';
 import { MongoMemoryServer } from 'mongodb-memory-server-core';
 import mongoose from 'mongoose';
 
@@ -7,43 +8,17 @@ let mongoServer: MongoMemoryServer | undefined;
 
 /**
  * Replace the database name in a MongoDB connection URI.
+ * Uses mongodb-connection-string-url package for robust parsing.
  * Supports various URI formats including authentication, replica sets, and query parameters.
- * Uses a simple string-based approach that handles most MongoDB URI formats correctly.
  * 
  * @param uri - MongoDB connection URI
  * @param newDbName - New database name to use
  * @returns Modified URI with the new database name
  */
 function replaceMongoDbName(uri: string, newDbName: string): string {
-  try {
-    // For standard single-host URIs, use URL API for robust parsing
-    // Format: mongodb://[username:password@]host[:port][/database][?options]
-    if (!uri.includes(',')) {
-      const url = new URL(uri);
-      url.pathname = `/${newDbName}`;
-      return url.toString();
-    }
-    
-    // For replica set URIs with multiple hosts (contains comma)
-    // Format: mongodb://host1:port1,host2:port2[/database][?options]
-    // URL API doesn't support multiple hosts, so use string manipulation
-    const [beforeDb, afterDb] = uri.split('?');
-    const queryString = afterDb ? `?${afterDb}` : '';
-    
-    // Find the last slash before the database name (after all hosts)
-    const lastSlashIndex = beforeDb.lastIndexOf('/');
-    if (lastSlashIndex > 'mongodb://'.length) {
-      // URI has a database name, replace it
-      const baseUri = beforeDb.substring(0, lastSlashIndex);
-      return `${baseUri}/${newDbName}${queryString}`;
-    }
-    
-    // URI has no database name, append it
-    return `${beforeDb}/${newDbName}${queryString}`;
-  } catch (error) {
-    // If parsing fails, throw an error with helpful message
-    throw new Error(`Failed to parse MongoDB URI: ${error instanceof Error ? error.message : String(error)}`);
-  }
+  const cs = new ConnectionString(uri);
+  cs.pathname = `/${newDbName}`;
+  return cs.href;
 }
 
 beforeAll(async () => {